Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document some antora build details #644

Merged
merged 4 commits into from
Aug 5, 2024
Merged

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Aug 5, 2024

During the last release we encountered some issues involving xrefs, I have now updated the troubleshooting page and docs overview explanation to make the component structure and xref mechanism more clear.

related to: #637

Copy link

netlify bot commented Aug 5, 2024

Deploy Preview for stackable-docs ready!

Name Link
🔨 Latest commit 939671f
🔍 Latest deploy log https://app.netlify.com/sites/stackable-docs/deploys/66b0987f057b81000823bdb1
😎 Deploy Preview https://deploy-preview-644--stackable-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fhennig

I also wonder if we can mimic the release branch process before the release (and before all of the dependent release branches exist)? Maybe it would catch the recent issues earlier.

@fhennig fhennig added this pull request to the merge queue Aug 5, 2024
Merged via the queue into main with commit a0246b6 Aug 5, 2024
6 checks passed
@fhennig fhennig deleted the add-more-antora-docs branch August 5, 2024 12:41
@fhennig
Copy link
Contributor Author

fhennig commented Aug 5, 2024

@NickLarsenNZ Yeah that would be nice. The issue happened because there were mistaken links from older versions onto stable. I think we purged them all now, so the issue cannot happen again. I'm more worried about new xrefs sneaking in that also reference 'home' explicitly.

The process to check for this in advance would be maybe to set pre-release to false in nightlyand see if anything breaks, but withouth publishing this change. I find it difficult to come up with a rigid process to do this, I'd lean towards not doing anything for now because of this. I feel like any sort of advance check would introduce too many new complexities that make it not worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants