Revert "Add proper startup, liveness and readiness probes (#273)" (#276)

This reverts commit 1f2e9a9.

The probes caused test failures when the opa authorizer was used.
See #275 for details.

CHANGELOG.md

@@ -9,14 +9,9 @@ All notable changes to this project will be documented in this file.
 - BREAKING: HDFS deep storage now configurable via HDFS discovery config map instead of an url to a HDFS name node ([#262]).
 - Include chart name when installing with a custom release name ([#263], [#264]).
 
-### Fixed
-
-- Add proper startup, liveness and readiness probes ([#273])
-
 [#262]: https://github.com/stackabletech/druid-operator/pull/262
 [#263]: https://github.com/stackabletech/druid-operator/pull/263
 [#264]: https://github.com/stackabletech/druid-operator/pull/264
-[#273]: https://github.com/stackabletech/druid-operator/pull/273
 
 ## [0.6.0] - 2022-06-30
 

rust/operator-binary/src/druid_controller.rs

@@ -2,7 +2,6 @@
 use crate::{
     config::{get_jvm_config, get_log4j_config},
     discovery::{self, build_discovery_configmaps},
-    probes::add_probes,
 };
 
 use snafu::{OptionExt, ResultExt, Snafu};
@@ -26,7 +25,9 @@ use stackable_operator::{
     k8s_openapi::{
         api::{
             apps::v1::{StatefulSet, StatefulSetSpec},
-            core::v1::{ConfigMap, EnvVar, Service, ServicePort, ServiceSpec},
+            core::v1::{
+                ConfigMap, EnvVar, Probe, Service, ServicePort, ServiceSpec, TCPSocketAction,
+            },
         },
         apimachinery::pkg::{apis::meta::v1::LabelSelector, util::intstr::IntOrString},
     },
@@ -595,7 +596,17 @@ fn build_rolegroup_statefulset(
             .build(),
     );
 
-    add_probes(&mut cb, &role);
+    // readiness probe
+    let probe = Probe {
+        tcp_socket: Some(TCPSocketAction {
+            port: IntOrString::Int(role.get_http_port().into()),
+            ..Default::default()
+        }),
+        initial_delay_seconds: Some(30),
+        period_seconds: Some(5),
+        ..Default::default()
+    };
+    cb.readiness_probe(probe);
 
     let mut container = cb.build();
     container.image_pull_policy = Some("IfNotPresent".to_string());

rust/operator-binary/src/main.rs

@@ -1,7 +1,6 @@
 mod config;
 mod discovery;
 mod druid_controller;
-mod probes;
 
 use std::sync::Arc;