Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hbase.zookeeper.property.clientPort setting #355

Closed
lfrancke opened this issue Apr 28, 2023 · 7 comments
Closed

Add hbase.zookeeper.property.clientPort setting #355

lfrancke opened this issue Apr 28, 2023 · 7 comments

Comments

@lfrancke
Copy link
Member

lfrancke commented Apr 28, 2023

We don't know why but while investigating another issue @sbernauer and I found that HBase was using the wrong port to connect to ZK despite the connection string looking good.

It might therefore be a good idea to just set the hbase.zookeeper.property.clientPort setting just to be safe:

  <property>
    <name>hbase.zookeeper.property.clientPort</name>
    <value>2282</value>
  </property>

The value needs to be read from ZK config

@sbernauer
Copy link
Member

Related to #354, might makes sense to implement together

@maltesander
Copy link
Member

What port is it connecting to? 2181? This should ideally be extracted from the discovery config map?
Currently 2181 and 2282 work because of the port unification if TLS is used anywhere (stackabletech/zookeeper-operator#480).

@sbernauer
Copy link
Member

We have a spike up and running, will raise PRs today @maltesander :)

@sbernauer
Copy link
Member

And yeah, we need to expose the port to use in the znode discovery cm

@sbernauer
Copy link
Member

sbernauer commented Apr 28, 2023

Just for the record some logs here

  <property>                                                                                                                                                                                                                                
    <name>hbase.zookeeper.property.clientPort</name>                                                                                                                                                                                        
    <value>2282</value>                                                                                                                                                                                                                     
  </property>                                                                                                                                                                                                                               
  <property>                                                                                                                                                                                                                                
    <name>hbase.zookeeper.quorum</name>                                                                                                                                                                                                     
    <value>test-zk-server-default-0.test-zk-server-default.kuttl-test-known-duck.svc.cluster.local:2282/znode-636de0b5-d08d-4c8a-afcb-a68623b3b6d4</value>                                                                                  
  </p
2023-04-28T08:06:17,269 DEBUG [ReadOnlyZKClient-test-zk-server-default-0.test-zk-server-default.kuttl-test-sound-bulldog.svc.cluster.local:2181@0x7ee7dcaf-SendThread(test-zk-server-default-0.test-zk-server-default.kuttl-test-sound-bulldog.svc.cluster.local:2181)] zookeeper.ClientCnxnSocketNIO: Ignoring exception during shutdown input
java.nio.channels.ClosedChannelException: null
        at sun.nio.ch.SocketChannelImpl.ensureOpen(SocketChannelImpl.java:160) ~[?:?]
        at sun.nio.ch.SocketChannelImpl.shutdownInput(SocketChannelImpl.java:913) ~[?:?]
        at sun.nio.ch.SocketAdaptor.shutdownInput(SocketAdaptor.java:398) ~[?:?]
        at org.apache.zookeeper.ClientCnxnSocketNIO.cleanup(ClientCnxnSocketNIO.java:198) ~[zookeeper-3.5.7.jar:3.5.7]
        at org.apache.zookeeper.ClientCnxn$SendThread.cleanup(ClientCnxn.java:1338) ~[zookeeper-3.5.7.jar:3.5.7]
        at org.apache.zookeeper.ClientCnxn$SendThread.cleanAndNotifyState(ClientCnxn.java:1276) ~[zookeeper-3.5.7.jar:3.5.7]
        at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1254) ~[zookeeper-3.5.7.jar:3.5.7]
2023-04-28T08:06:17,269 DEBUG [ReadOnlyZKClient-test-zk-server-default-0.test-zk-server-default.kuttl-test-sound-bulldog.svc.cluster.local:2181@0x7ee7dcaf-SendThread(test-zk-server-default-0.test-zk-server-default.kuttl-test-sound-bulldog.svc.cluster.local:2181)] zookeeper.ClientCnxnSocketNIO: Ignoring exception during shutdown output
java.nio.channels.ClosedChannelException: null
        at sun.nio.ch.SocketChannelImpl.ensureOpen(SocketChannelImpl.java:160) ~[?:?]
        at sun.nio.ch.SocketChannelImpl.shutdownOutput(SocketChannelImpl.java:930) ~[?:?]
        at sun.nio.ch.SocketAdaptor.shutdownOutput(SocketAdaptor.java:406) ~[?:?]
        at org.apache.zookeeper.ClientCnxnSocketNIO.cleanup(ClientCnxnSocketNIO.java:205) ~[zookeeper-3.5.7.jar:3.5.7]
        at org.apache.zookeeper.ClientCnxn$SendThread.cleanup(ClientCnxn.java:1338) ~[zookeeper-3.5.7.jar:3.5.7]
        at org.apache.zookeeper.ClientCnxn$SendThread.cleanAndNotifyState(ClientCnxn.java:1276) ~[zookeeper-3.5.7.jar:3.5.7]
        at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1254) ~[zookeeper-3.5.7.jar:3.5.7]```

@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Apr 28, 2023
@sbernauer sbernauer self-assigned this Apr 28, 2023
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Apr 28, 2023
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering May 2, 2023
bors bot pushed a commit that referenced this issue May 2, 2023
@lfrancke
Copy link
Member Author

lfrancke commented May 5, 2023

This can be closed, right?

@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering May 5, 2023
@sbernauer
Copy link
Member

Yes

@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants