Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix zookeeper quorum and port configuration #357

Closed
wants to merge 8 commits into from

Conversation

sbernauer
Copy link
Member

Description

Fixes #354 and #355

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@sbernauer sbernauer self-assigned this Apr 28, 2023
@maltesander maltesander self-requested a review April 28, 2023 14:18
@lfrancke lfrancke self-requested a review April 28, 2023 14:23
@lfrancke lfrancke removed their request for review April 28, 2023 14:27
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just minor things

CHANGELOG.md Outdated Show resolved Hide resolved
rust/operator-binary/src/zookeeper.rs Outdated Show resolved Hide resolved
@sbernauer
Copy link
Member Author

@sbernauer
Copy link
Member Author

bors r+
Test passed

bors bot pushed a commit that referenced this pull request May 2, 2023
@bors
Copy link
Contributor

bors bot commented May 2, 2023

Pull request successfully merged into main.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title Fix zookeeper quorum and port configuration [Merged by Bors] - Fix zookeeper quorum and port configuration May 2, 2023
@bors bors bot closed this May 2, 2023
@bors bors bot deleted the fix/zk-stuff branch May 2, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hbase.zookeeper.quorum may be built wrong, zookeeper.znode.parent not set
2 participants