Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support user authentication using Kerberos #436

Merged
merged 37 commits into from
Jan 19, 2024
Merged

Support user authentication using Kerberos #436

merged 37 commits into from
Jan 19, 2024

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Jan 9, 2024 •
edited by lfrancke
Loading

Description

Closes #285

Missing

  • docs
  • tests for accessing restserver
  • docs on discovery

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Beta Give feedback

Reviewer
Beta Give feedback

Acceptance
Beta Give feedback

sbernauer
sbernauer commented Jan 10, 2024
View reviewed changes
ycsb.yaml Outdated Show resolved Hide resolved
@sbernauer sbernauer changed the title WIP: Kerberos support Allow enabling user authentication with Kerberos Jan 10, 2024
@sbernauer sbernauer marked this pull request as ready for review January 15, 2024 12:22
@sbernauer
Copy link
Member Author

It would be great if someone could review the actual code, docs will follow

@sbernauer sbernauer self-assigned this Jan 15, 2024
@sbernauer sbernauer changed the title Allow enabling user authentication with Kerberos Support user authentication using Kerberos Jan 16, 2024
@maltesander maltesander self-requested a review January 16, 2024 16:41
maltesander
maltesander reviewed Jan 16, 2024
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First batch, will continue and test tomorrow!

docs/modules/hbase/pages/usage-guide/security.adoc Outdated Show resolved Hide resolved
docs/modules/hbase/pages/usage-guide/security.adoc Outdated Show resolved Hide resolved
docs/modules/hbase/pages/usage-guide/security.adoc Outdated Show resolved Hide resolved
docs/modules/hbase/pages/usage-guide/security.adoc Outdated Show resolved Hide resolved
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/kerberos.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/kerberos.rs Show resolved Hide resolved
tests/templates/kuttl/kerberos/42-test-rest-server.yaml Show resolved Hide resolved
rust/operator-binary/src/hbase_controller.rs Show resolved Hide resolved
rust/operator-binary/src/hbase_controller.rs Outdated Show resolved Hide resolved
@sbernauer
Copy link
Member Author

Started https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hbase-operator-it-custom/131/

@sbernauer
Copy link
Member Author

Just to be sure: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hbase-operator-it-custom/132

maltesander
maltesander approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer
Copy link
Member Author

Many thanks for the quick review!

@sbernauer sbernauer added this pull request to the merge queue Jan 19, 2024
Merged via the queue into main with commit 55f6317 Jan 19, 2024
30 checks passed
@sbernauer sbernauer deleted the feat/kerberos-reloaded branch January 19, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

@sbernauer sbernauer

Labels
release/2024-03
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow enabling user authentication with Kerberos
3 participants
@sbernauer @maltesander @lfrancke