Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix: Increase default pvc size to 1Gi as required by IONOS #365

Closed
wants to merge 6 commits into from

Conversation

sbernauer
Copy link
Member

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass (maybe add a changelong entry for the why?)

@sbernauer
Copy link
Member Author

I don't think this must be mentioned explicitly in the changelog, as this is IMHO an detail of how we decided on what sizes the pcvs should have by default

@sbernauer
Copy link
Member Author

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Edit: The kerberos tests failed?

@sbernauer
Copy link
Member Author

@sbernauer
Copy link
Member Author

@sbernauer sbernauer requested review from Techassi and removed request for Techassi July 3, 2023 08:39
@sbernauer
Copy link
Member Author

bors r+
Thanks for review, tests have passed 🚀

bors bot pushed a commit that referenced this pull request Jul 3, 2023
# Description

*Please add a description here. This will become the commit message of the merge request later.*
@bors
Copy link
Contributor

bors bot commented Jul 3, 2023

Pull request successfully merged into main.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title fix: Increase default pvc size to 1Gi as required by IONOS [Merged by Bors] - fix: Increase default pvc size to 1Gi as required by IONOS Jul 3, 2023
@bors bors bot closed this Jul 3, 2023
@bors bors bot deleted the fix/pvc-size branch July 3, 2023 09:08
@sbernauer sbernauer self-assigned this Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants