Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: Support podOverrides #368

Closed
wants to merge 2 commits into from

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Jul 3, 2023

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good.
some docs and a test run are missing

@sbernauer
Copy link
Member Author

For the docs we have https://docs.stackable.tech/home/nightly/concepts/overrides.html#_pod_overrides, is that sufficient for you?

@razvan
Copy link
Member

razvan commented Jul 3, 2023

It's sufficient for me. I thought we want to link it from the operator docs

@sbernauer
Copy link
Member Author

Happy to do so, any recommendation from where exactly we want to link? Goes along with the questions of how hard we want to try to avoid users using podOverrides ^^

@sbernauer
Copy link
Member Author

@sbernauer
Copy link
Member Author

bors r+
Added a test, which passed locally

bors bot pushed a commit that referenced this pull request Jul 4, 2023
# Description

*Please add a description here. This will become the commit message of the merge request later.*
@sbernauer sbernauer self-assigned this Jul 4, 2023
@bors
Copy link
Contributor

bors bot commented Jul 4, 2023

Pull request successfully merged into main.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: Support podOverrides [Merged by Bors] - feat: Support podOverrides Jul 4, 2023
@bors bors bot closed this Jul 4, 2023
@bors bors bot deleted the feat/pod-overrides branch July 4, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants