Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to use a custom image in tests #550

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Conversation

lfrancke
Copy link
Member

@lfrancke lfrancke commented Jul 13, 2024

Description

Make it easier to use a custom image in tests. This follows the best practice from other operators.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

@lfrancke lfrancke self-assigned this Jul 13, 2024
@adwk67
Copy link
Member

adwk67 commented Sep 11, 2024

Successfully tested:

nightly, with only the custom image:

--- PASS: kuttl (2872.22s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/kerberos_hadoop-latest-3.4.0,docker.stackable.tech_sandbox_hadoop_3.4.0-stackable0.0.0-dev_zookeeper-latest-3.9.2_krb5-1.21.1_kerberos-realm-CLUSTER.LOCAL_kerberos-backend-mit_openshift-false (503.86s)
        --- PASS: kuttl/harness/smoke_hadoop-3.4.0,docker.stackable.tech_sandbox_hadoop_3.4.0-stackable0.0.0-dev_zookeeper-3.9.2_zookeeper-latest-3.9.2_number-of-datanodes-2_datanode-pvcs-2hdd-1ssd_listener-class-cluster-internal_openshift-false (265.98s)
        --- PASS: kuttl/harness/orphaned-resources_hadoop-latest-3.4.0,docker.stackable.tech_sandbox_hadoop_3.4.0-stackable0.0.0-dev_zookeeper-latest-3.9.2_openshift-false (158.33s)
        --- PASS: kuttl/harness/logging_hadoop-3.4.0,docker.stackable.tech_sandbox_hadoop_3.4.0-stackable0.0.0-dev_zookeeper-latest-3.9.2_openshift-false (541.16s)
        --- PASS: kuttl/harness/smoke_hadoop-3.4.0,docker.stackable.tech_sandbox_hadoop_3.4.0-stackable0.0.0-dev_zookeeper-3.9.2_zookeeper-latest-3.9.2_number-of-datanodes-2_datanode-pvcs-2hdd-1ssd_listener-class-external-unstable_openshift-false (221.40s)
        --- PASS: kuttl/harness/cluster-operation_hadoop-latest-3.4.0,docker.stackable.tech_sandbox_hadoop_3.4.0-stackable0.0.0-dev_zookeeper-latest-3.9.2_openshift-false (331.24s)
        --- PASS: kuttl/harness/profiling_hadoop-3.4.0,docker.stackable.tech_sandbox_hadoop_3.4.0-stackable0.0.0-dev_zookeeper-latest-3.9.2_openshift-false (140.37s)
        --- PASS: kuttl/harness/topology-provider_hadoop-latest-3.4.0,docker.stackable.tech_sandbox_hadoop_3.4.0-stackable0.0.0-dev_zookeeper-latest-3.9.2_krb5-1.21.1_kerberos-backend-mit_openshift-false (285.88s)
        --- PASS: kuttl/harness/kerberos_hadoop-latest-3.4.0,docker.stackable.tech_sandbox_hadoop_3.4.0-stackable0.0.0-dev_zookeeper-latest-3.9.2_krb5-1.21.1_kerberos-realm-PROD.MYCORP_kerberos-backend-mit_openshift-false (423.65s)
PASS

Smoke tests, mixed custom/non-custom images:

--- PASS: kuttl (337.05s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_hadoop-3.3.6_zookeeper-3.9.2_zookeeper-latest-3.9.2_number-of-datanodes-1_datanode-pvcs-2hdd-1ssd_listener-class-cluster-internal_openshift-false (207.44s)
        --- PASS: kuttl/harness/smoke_hadoop-3.4.0,docker.stackable.tech_sandbox_hadoop_3.4.0-stackable0.0.0-dev_zookeeper-3.9.2_zookeeper-latest-3.9.2_number-of-datanodes-1_datanode-pvcs-2hdd-1ssd_listener-class-cluster-internal_openshift-false (129.27s)
PASS

@adwk67 adwk67 self-requested a review September 11, 2024 06:35
# Conflicts:
#	tests/test-definition.yaml
@lfrancke lfrancke marked this pull request as ready for review September 11, 2024 06:51
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lfrancke lfrancke added this pull request to the merge queue Sep 11, 2024
Merged via the queue into main with commit 1bbad4c Sep 11, 2024
31 checks passed
@lfrancke lfrancke deleted the feat/configurable-tests branch September 11, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants