Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support non-default cluster domain #591

Merged
merged 12 commits into from
Oct 23, 2024
Merged

feat: Support non-default cluster domain #591

merged 12 commits into from
Oct 23, 2024

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Oct 18, 2024

Description

Part of stackabletech/issues#652

  • grepped for cluster.local and fixed
  • changelog (if needed)
  • values.yaml comment

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise!

deploy/helm/hdfs-operator/values.yaml Outdated Show resolved Hide resolved
deploy/helm/hdfs-operator/values.yaml Outdated Show resolved Hide resolved
rust/operator-binary/src/config.rs Outdated Show resolved Hide resolved
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit 3898118 Oct 23, 2024
31 checks passed
@sbernauer sbernauer deleted the op-rs-0.79.0 branch October 23, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants