-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate kafka-operator to use listener-operator for exposing brokers #443
base: main
Are you sure you want to change the base?
Conversation
This is far from final (for example, we'd need to expose a configurable LoadBalancerClass, for example), but I wanted to see whether lb-op would be a good fit for this operator first.
9c751ca
to
6c9c18f
Compare
Blocked on stackabletech/listener-operator#1 |
Tested and works! |
…erator into spike/lb-operator
7e287d8
to
1f5a4e5
Compare
I've moved this back into "Ready for Development" because the Listener operator is now merged. AFAIU this should now be ready to be worked on again? |
This pull request is updated as requested by stackabletech/listener-operator#5. When stackabletech/operator-rs#496 is merged and operator-rs and the listener-operator are released then this pull request can be made ready for review. |
Tests currently fail due to stackabletech/listener-operator#110. |
The tests now pass! |
@nightkr do you plan to merge this or add the WIP functionality of secret-op beforehand, so that the kafka broker certificates will include the listener addresses? |
Preferably not, since we're still working out a few API kinks there (truststore passwords), and I'd rather keep this PR focused. ^^ |
@nightkr given you opened stackabletech/operator-rs#858 (reviewed it), I would be very in favor of putting the listenerVolume scope on the secret-op mount, so that we have valid certificates. |
Yes, that was why I opened that PR ^^ |
Current (known) issues:
2 and 3 come from currently using a single shared bootstrap listener.. simpler for kafka-op and arguably where we want the UX to go, but means we'll probably want to fix it. Arguably 3 is desirable, since this only affects initial bootstrap anyway. |
stackabletech/operator-rs#861 is also a pretty blocking issue for this. |
This isn't ready to merge yet (there are still open blockers), but the gist should be reviewable now. |
Description
Fixes #714.
Blockers:
ClusterResources::delete_orphaned_resources
also deletes objects that are not owned directly by it operator-rs#861Followup issues/regressions:
Review Checklist
Once the review is done, comment
bors r+
(orbors merge
) to merge. Further information