Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support graceful shutdown #635

Merged
merged 6 commits into from
Nov 6, 2023
Merged

feat: Support graceful shutdown #635

merged 6 commits into from
Nov 6, 2023

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Nov 6, 2023 •
edited by lfrancke
Loading

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

@sbernauer sbernauer force-pushed the feat/graceful-shutdown branch from 8e368c8 to d2f240d Compare November 6, 2023 09:28
@sbernauer sbernauer mentioned this pull request Nov 6, 2023
Closed
@sbernauer sbernauer self-assigned this Nov 6, 2023
@maltesander maltesander self-requested a review November 6, 2023 09:46
maltesander
maltesander requested changes Nov 6, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some doc nitpicking and changelog. LGTM otherwise.

CHANGELOG.md Outdated Show resolved Hide resolved
docs/modules/kafka/pages/usage-guide/operations/graceful-shutdown.adoc Outdated Show resolved Hide resolved
docs/modules/kafka/pages/usage-guide/operations/graceful-shutdown.adoc Outdated Show resolved Hide resolved
docs/modules/kafka/pages/usage-guide/operations/graceful-shutdown.adoc Outdated Show resolved Hide resolved
@sbernauer
Copy link
Member Author

Started https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/kafka-operator-it-custom/53/

maltesander
maltesander approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if test passes!

@sbernauer sbernauer enabled auto-merge November 6, 2023 10:33
@sbernauer sbernauer added this pull request to the merge queue Nov 6, 2023
Merged via the queue into main with commit 2117297 Nov 6, 2023
29 checks passed
@sbernauer sbernauer deleted the feat/graceful-shutdown branch November 6, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

@sbernauer sbernauer

Labels
release/23.11.0
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbernauer @maltesander @lfrancke