-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Kerberos authentication for Kafka #762
Conversation
@sbernauer I tried to use one principal for all brokers, as we discussed, but could not quite get it to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only did a quick review of the code. I can go into more detail when we merged the changes from #443 and I find the proper time
Co-authored-by: Sebastian Bernauer <[email protected]>
Co-authored-by: Sebastian Bernauer <[email protected]>
Ran nightly suite again locally following latest changes 🟢
|
Re-tested 🟢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good explanation!
Co-authored-by: Siegfried Weber <[email protected]>
All changes implemented and/or discussed in planning (will merge as experimental).
Fixes #655
Pending decision: https://github.com/stackabletech/decisions/issues/28 ( ✔️ closed/done)
Openshift/OKD tests 🟢 :
Definition of Done Checklist
Author
Reviewer
Acceptance