Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate -nodeport discovery ConfigMap #813

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Jan 22, 2025

Description

See #765

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback
No tasks being tracked yet.

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@nightkr
Copy link
Member Author

nightkr commented Jan 22, 2025

Release note:

The -nodeport discovery ConfigMaps have been deprecated for removal. Use the primary discovery CMs instead. See #765 for more information.

@nightkr nightkr requested a review from a team January 22, 2025 16:23
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@nightkr nightkr added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit 26b1220 Jan 23, 2025
17 checks passed
@nightkr nightkr deleted the chore/deprecate-nodeport-discovery branch January 23, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Development: Done
Development

Successfully merging this pull request may close these issues.

2 participants