Skip to content

Conversation

@razvan
Copy link
Member

@razvan razvan commented Oct 24, 2025

Description

Tested with OLM manifests from stackabletech/openshift-certified-operators#21
Those manifests use this PR's operator image.

🟢 Tests on OpenShift 4.17

$ ./scripts/run-tests --test-suite openshift --skip-delete --skip-release
...
--- PASS: kuttl (147.04s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/custom-lbclass_openshift-true_loadbalancer-allocatenodeports-false (1.21s)
        --- PASS: kuttl/harness/smoke-nodeport_openshift-true_addressType-Hostname (11.79s)
        --- PASS: kuttl/harness/smoke-nodeport_openshift-true_addressType-IP (134.93s)
        --- PASS: kuttl/harness/custom-lbclass_openshift-true_loadbalancer-allocatenodeports-true (1.21s)
        --- PASS: kuttl/harness/smoke-nodeport_openshift-true_addressType-HostnameConservative (134.90s)
PASS

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@razvan razvan self-assigned this Oct 24, 2025
@razvan razvan changed the title Chore/update-olm chore: update olm deployer Oct 24, 2025
@razvan razvan marked this pull request as ready for review October 24, 2025 13:39
@razvan razvan requested a review from a team October 24, 2025 13:39
@razvan razvan moved this to Development: Waiting for Review in Stackable Engineering Oct 24, 2025
@adwk67 adwk67 requested review from adwk67 and removed request for a team October 24, 2025 13:50
@adwk67 adwk67 moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 24, 2025
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@razvan razvan added this pull request to the merge queue Oct 24, 2025
@razvan
Copy link
Member Author

razvan commented Oct 24, 2025

thanks!

@razvan razvan moved this from Development: In Review to Development: Done in Stackable Engineering Oct 24, 2025
Merged via the queue into main with commit ff9bec0 Oct 24, 2025
17 checks passed
@razvan razvan deleted the chore/update-olm branch October 24, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: Done

Development

Successfully merging this pull request may close these issues.

2 participants