Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stackable-operator)!: Reduce CRD size by omitting podOverride and affinities schemas #821

Merged
merged 10 commits into from
Aug 2, 2024
Merged

feat(stackable-operator)!: Reduce CRD size by omitting podOverride and affinities schemas #821

merged 10 commits into from
Aug 2, 2024

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Jul 2, 2024 •
edited
Loading

Description

See changelog entry.

Tested it in the druid-operator and podOverrides and affinitites still kept working

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

@sbernauer sbernauer self-assigned this Jul 2, 2024
@sbernauer sbernauer mentioned this pull request Jul 2, 2024
Merged
@Techassi Techassi changed the title feat!: Reduce CRD size by omitting podOverride and affinities schemas feat(stackable-operator)!: Reduce CRD size by omitting podOverride and affinities schemas Jul 5, 2024
Techassi
Techassi reviewed Jul 5, 2024
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one suggestion.

crates/stackable-operator/CHANGELOG.md Outdated Show resolved Hide resolved
@sbernauer sbernauer requested a review from Techassi July 5, 2024 10:17
Techassi
Techassi previously approved these changes Jul 5, 2024
View reviewed changes
Techassi
Techassi previously approved these changes Jul 15, 2024
View reviewed changes
@NickLarsenNZ
Copy link
Member

Pending decision stackabletech/druid-operator#584

@sbernauer
Copy link
Member Author

The decision was accepted, going to merge :)

NickLarsenNZ
NickLarsenNZ requested changes Aug 2, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just changelogs need fixing (duplicate Changes sections with outdated content).

crates/k8s-version/CHANGELOG.md Show resolved Hide resolved
NickLarsenNZ
NickLarsenNZ approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer sbernauer added this pull request to the merge queue Aug 2, 2024
Merged via the queue into main with commit 9bbf093 Aug 2, 2024
20 checks passed
@sbernauer sbernauer deleted the feat/reduce-crd-size branch August 2, 2024 12:30
@sbernauer sbernauer mentioned this pull request Aug 9, 2024
Merged
@sbernauer sbernauer mentioned this pull request Aug 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

@Techassi Techassi Awaiting requested review from Techassi

Assignees

@sbernauer sbernauer

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbernauer @NickLarsenNZ @Techassi