Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tls-pkcs12-trustore format #387

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add tls-pkcs12-trustore format #387

wants to merge 3 commits into from

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Mar 15, 2024

Description

For stackabletech/issues#547
Even if we don't merge this, we probably want the new tests and doc fix

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

@sbernauer sbernauer marked this pull request as draft March 15, 2024 10:53
@sbernauer sbernauer changed the title First implementation Support tls-pkcs12-trustore format Mar 15, 2024
@sbernauer sbernauer changed the title Support tls-pkcs12-trustore format Add tls-pkcs12-trustore format Mar 15, 2024
@sbernauer
Copy link
Member Author

The plan is to have a new annotation (such as secrets.stackable.tech/provision-identity as a boolean or e.g. some other attribute with e.g. values public / private), which controls if you only get the public parts (ca.crt for tls-pem, trsustore for tls-pkcs12 and krb5.conf for kerberos) or all parts (as currently done).
For compatibility reasons we should probably default to only the private parts. In operator-rs the SecretOperatorVolumeBuilder needs to expose this new attribute, it IMHo should be made mandatory, so every product operators needs to make a call what exactly he needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant