-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure a spark application can only be submitted once #460
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality LGTM, only some style questions
Co-authored-by: Sebastian Bernauer <[email protected]>
Co-authored-by: Sebastian Bernauer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can you please run a Jenkins custom test before merge?
Co-authored-by: Sebastian Bernauer <[email protected]>
Co-authored-by: Nick <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
Fixes #457
Kubernetes recycles Spark applications jobs after
ttlSecondsAfterFinished
(10min currently) but the application objects live forever (or until the user deletes them).If a reconciliation is triggered on an app that has no child Job, the operator will submit the Job again.
The fix is to use the application's status field as guard for the reconciliation loop.
I tested it by:
--skip-delete
🟢 CI: https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/4/
Definition of Done Checklist
Author
Reviewer
Acceptance