-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bazel 6.4.0, rules_go v0.45, bazel-gazelle 0.35, more... #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de8f383
to
a96563d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a large PR that includes:
6.4.0
(was5.4.0
)//external:BUILD.bazel
to use the (new) yaml config file//:rules_proto_config.yaml
, which works as a default config forstackb/rules_proto
consumers.//:gazelle
target in this repository to useproto_gazelle
, referencing the imports from otherproto_repository
rules.--js_out
is no longer bundled withprotoc
. A new dependency toprotocolbuffers/protobuf-javascript
added. New top-leveljs_core_deps.bzl
macro.WORKSPACE
re-orggoogle/protobuf/timestamp.proto
until ts_proto can deal correctly with external repositories.go
version to 1.18pkg/protoc/resolver.go
to deal with feat(resolve): optimize applying overrides to be efficient bazel-contrib/bazel-gazelle#1687.Upgrades:
bazelbuild/io_bazel_rules_go
upgraded from0.39.1
to0.44.1
bazelbuild/bazel_gazelle
upgraded from0.31.0
to0.35.0
bazelbuild/rules_proto
upgraded tof9b0b880d1e10e18daeeb168cef9d0f8316fdcb5
(latest)protocolbuffers/protobuf
upgraded from3.20.1
tov21.12
. NOTE: Theprotobuf-javascript
repo is stuck on v21 and needs to be migrated to use selected abseil imports rather than older imports that were previously vendored into protobuf repo.grpc/grpc
upgraded from1.54.1
to1.54.3
grpc-web
upgraded from1.4.2
to1.5.0