feat: add Svelte language to CodeMirror #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
adrianmroz
force-pushed
the
add-svelte-language-to-codemirror
branch
from
aaeb47a
to
57e1114
Compare
adrianmroz
changed the title
adrianmroz
changed the title
Nemikolh
reviewed
Aug 5, 2024
There was a problem hiding this comment.
Hey @adrianmroz! Thanks a lot for the PR! 😃
This looks pretty good!
Only a few more steps and we can merge your PR:
- The dependency seems to need a few
peerDependencies:@lezer/common,@lezer/javascript,@lezer/lr. Could you add them explicitly to thepackage.jsonas well? - The lock file needs to be updated. You can do that with
pnpm iat the root of the workspace.
If you want to test your changes you can then do:
pnpm dev
You can add a temporary svelte file in packages/template/src/content/tutorial/1-basics/1-introduction/1-welcome/_files, you navigate to http://localhost:4321/ and check that the syntax highlighting works as expected.
Let me know if you run into any issues!
adrianmroz
force-pushed
the
add-svelte-language-to-codemirror
branch
from
57e1114
to
cdb8ff5
Compare
|
I've pushed changes to dependencies and lock file. I also checked example file for syntax highlighting. It is not perfect, but much better than nothing :) Let me know if I still missed something. |
Nemikolh
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should solve #211