Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runtime): option for setting terminal open by default #246

Merged
merged 5 commits into from
Aug 19, 2024

Conversation

AriPerkkio
Copy link
Member

@AriPerkkio AriPerkkio commented Aug 15, 2024

Adds new terminal.open option that can be used to set terminal open by default for specific lesson.

---
type: lesson
title: Default
terminal:
  open: true       # <-- Terminal will be open when page is navigated to
  panels: terminal
---

Copy link

stackblitz bot commented Aug 15, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Comment on lines +13 to +16
/* eslint-disable multiline-comment-style */
// TODO: Requires #245
// await expect(tab).not.toBeVisible();
// await expect(panel).not.toBeVisible();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@Nemikolh Nemikolh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on this!! 🎉

@Nemikolh Nemikolh merged commit 5419038 into stackblitz:main Aug 19, 2024
9 checks passed
@AriPerkkio AriPerkkio deleted the feat/terminal-open branch August 19, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add terminalOpen to frontmatter metadata
2 participants