Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): solve-button not working before lesson loads #266

Merged

Conversation

AriPerkkio
Copy link
Member

If Solve-button is clicked quickly enough, it does not reveal the solution files. It does change the button text to "Reset" which is not true in that case.

solve() {
const isReady = this.lessonFullyLoaded.value;
if (!isReady || !this._lessonSolution) {
return;
}

Copy link

stackblitz bot commented Aug 20, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@Nemikolh Nemikolh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 🤩

@Nemikolh Nemikolh merged commit 547e70a into stackblitz:main Aug 20, 2024
9 checks passed
@AriPerkkio AriPerkkio deleted the fix/solve-button-not-responding branch August 20, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants