docs: TopBar override to mention open-in-stackblitz-link slot
#324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AriPerkkio
changed the title
TopBar override to mention open-in-stackblitz slotTopBar override to mention open-in-stackblitz-link slot
Nemikolh
reviewed
Sep 11, 2024
Comment on lines
+16
to
+20
| vite: { | ||
| ssr: { | ||
| noExternal: '@tutorialkit/react', | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Without this, locally run pnpm run docs crashes when react components page is opened in browser.
I verified that documentation still works after this change by running pnpm run build; pnpm run preview for the docs.
There was a problem hiding this comment.
Woow I did noticed that once but thought it might have been my local environment having a bug!!
Really good find! 🤩
Thanks for the explanation 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TopBar#112