Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(astro): override components to support Dialog #345

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

AriPerkkio
Copy link
Member

Adds support for overriding Dialog. Also adds e2e tests for Override Components -feature.

import tutorialkit from '@tutorialkit/astro';
import { defineConfig } from 'astro/config';

export default defineConfig({
  integrations: [
    tutorialkit({
      components: {
        Dialog: './src/components/Dialog.tsx',
      },
    }),
  ],
});

Copy link

stackblitz bot commented Sep 23, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@AriPerkkio
Copy link
Member Author

/pkg-pr-new

@AriPerkkio AriPerkkio force-pushed the feat/override-dialog branch 3 times, most recently from 78c51c7 to 12231c2 Compare September 23, 2024 11:40
@AriPerkkio AriPerkkio marked this pull request as ready for review September 23, 2024 11:45
Copy link
Member

@Nemikolh Nemikolh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! Much simpler than what I thought it would be 🎉

Copy link
Member

@Nemikolh Nemikolh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! 🌟 Good work on this @AriPerkkio 💪

@AriPerkkio AriPerkkio merged commit 61a542e into stackblitz:main Sep 24, 2024
10 checks passed
@AriPerkkio AriPerkkio deleted the feat/override-dialog branch September 24, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants