Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: mark @tutorialkit/react component API as experimental feature #346

Conversation

AriPerkkio
Copy link
Member

  • Marks direct usage of @tutorialkit/react as experimental feature
  • This does not affect users of TutorialKit. This affects only users who are using @tutorialkit/react without TutorialKit itself

The components of @tutorialkit/react are exposed as public API but we don't have any test cases for these components. We only have e2e tests through @tutorialkit/astro. When ever we implement new features to @tutorialkit/astro, we need to pay extra attention not to introduce any new required component props, or modify any existing ones to avoid semver breaking changes. Breaking the API is too easy at the moment and not easily visible from the code.

Now that we are still in v0.x.x version, let's mark @tutorialkit/react API as experimental. This allows us to keep breaking the API when needed. Once we get more test cases and see that implementing new features doesn't require breaking the API anymore, let's remove the experimental status.

@AriPerkkio AriPerkkio added documentation Change related to TutorialKit documentation or demo site breaking changes labels Sep 24, 2024
Copy link

stackblitz bot commented Sep 24, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Comment on lines +25 to +31
:::note
Using `@tutorialkit/react` package directly without `@tutorialkit/astro` is **experimental** at the moment.
This package may introduce breaking changes in patch and minor version updates. Pay extra attention when updating the versions.

We are planning to stabilize component API of `@tutorialkit/react` in future.
:::

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This renders to

@AriPerkkio AriPerkkio mentioned this pull request Sep 24, 2024
29 tasks
Copy link
Member

@Nemikolh Nemikolh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good!

@Nemikolh Nemikolh merged commit 67042ef into stackblitz:main Sep 24, 2024
10 checks passed
@AriPerkkio AriPerkkio deleted the docs/react-components-experimental-feature branch September 24, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking changes documentation Change related to TutorialKit documentation or demo site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants