Prevent Cloud-init erasing LINKDELAY #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloud-init uses default generated network config to try and configure a link for DHCP. This overwrites the LINKDELAY setting, which is required in some cases to bring up the link.
markgoddard
reviewed
Aug 6, 2019
| @@ -8,3 +8,5 @@ set -o pipefail | |||
|
|
|||
| # Add a LINKDELAY value to /etc/sysconfig/network | |||
| echo -e "# Allow extra time for link up\nLINKDELAY=${CENTOS_LINKUP_EXTRA_SECS}" >> /etc/sysconfig/network | |||
| # Prevent Cloudinit writing over LINKDELAY setting | |||
| echo -e "network: {config: disabled}" >> /etc/cloud/cloud.cfg.d/99-disable-custom-net-conf.cfg | |||
There was a problem hiding this comment.
This seems like quite a drastic thing to always do. Network bootstrapping is a big part of cloud-init. Would it not also break network configuration provided via config-drive?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloud-init uses default generated network config to try and configure
a link for DHCP. This overwrites the LINKDELAY setting, which is required
in some cases to bring up the link.
This prevents the configuration of a udev rule by cloud init and the addition of the MAC address to the ifcfg script for the active interface. DNS still appears to be configured, but is missing the 'configured by Cloud init header'. None of these issues appear to prevent the image booting, running cloud-init and enabling the user to log in on a test node connected to a single network.