-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the rocky-container-generic element #48
base: master
Are you sure you want to change the base?
Conversation
0f55f4b
to
90858e4
Compare
So, cloud-init should use cloud-user, even for centos it should (because on RHEL8/9 it uses cloud-user) - it seems getting a ,,centos'' user is a bug (canonical/cloud-init#1639). |
This makes the rocky-container build more like the generic cloud image, see: https://git.rockylinux.org/rocky/kickstarts/-/blob/r8/Rocky-8-GenericCloud.ks
748f21e
to
c667705
Compare
Interesting, I guess it makes sense to use the upstream default of cloud-user. It was just something @priteau brought up as the kayobe bootstrap user defaults to os_distribution. This matches what is configured in the generic cloud image: https://git.rockylinux.org/rocky/kickstarts/-/blob/r8/Rocky-8-GenericCloud.ks#L107-109 but not what you get when using rocky-container.
Some of these packages aren't really necessary in a container, but make sense when creating a bootable image from it. I Imagine they'd want to keep their base container clean. |
So then I guess it could be accepted in DIB's rocky-container element - or we can have it in our custom collection. |
Can end up removing dependencies from other elements, so its porbbaly best to keep this list minimal.
I noticed they are still setting cloud-user to rocky in the rocky 9 generic image: https://git.rockylinux.org/rocky/kickstarts/-/blob/r9/Rocky-9-GenericCloud.ks#L107-109 |
I've submitted upstream here: https://review.opendev.org/c/openstack/diskimage-builder/+/855521. Awaiting feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable
Remove non-existing package
Having booted a genericcloud8.6 image,
|
@jovial there's quite a lot of package changes - obviously lots are just updates which is wanted/as-expected, don't know if you want to address any added/removed ones:
|
The above just used Rocky-8-GenericCloud-8.6.20220702.0.x86_64.qcow2 as the "old" side of the diff, with no yum update or anything. |
@@ -0,0 +1,3 @@ | |||
rocky-container |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this also depend on vm
? Without it you get an error "element block_device not found"
@@ -0,0 +1,73 @@ | |||
# List taken from https://git.rockylinux.org/rocky/kickstarts/-/blob/r8/Rocky-8-GenericCloud.ks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment #48 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also - it should include a README, probably based on the rocky-container
README.
This makes the rocky-container build more like the generic cloud
image, see:
https://git.rockylinux.org/rocky/kickstarts/-/blob/r8/Rocky-8-GenericCloud.ks