-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INFRA-709 Rated dwpd alerts #1077
base: stackhpc/2023.1
Are you sure you want to change the base?
Conversation
c3561f1
to
16cb223
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent piece of work @technowhizz . Please see if you can simplify it by writing out the DWPD file separately. Unless I've missed something?
command: "nvme list -o json" | ||
register: nvme_list | ||
changed_when: false | ||
become: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Is root required? At least on Fedora 40 it doesn't appear to be. Feel free to ignore if you're not sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if all disks are listed if not root
|
||
- name: Create a DWPD ratings file | ||
copy: | ||
content: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could just be the raw file that you write out above when running the playbook?
@technowhizz what do we need to do to get this moving again? It looks like a lot of work and I don't want it to go to waste |
Now we have started on the Python script it makes sense to finish that first and then come back to this. |
This PR allows the operator to specify the rated DWPD of a disk and have it show up in prometheus