Skip to content

feature(core): Add wait handler structure #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feature(core): Add wait handler structure #19

wants to merge 3 commits into from

Conversation

@Fyusel
Copy link
Contributor

@Fyusel Fyusel commented Sep 5, 2025 •
edited
Loading

Description

relates to STACKITSDK-232

Checklist

  • Issue was linked above
  • No generated code was adjusted manually
  • Changelogs
    • Changelog in the root directory was adjusted
    • Changelog(s) of the service(s) were adjusted
  • VERSION file(s) of the service(s) were adjusted
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@Fyusel Fyusel requested a review from a team as a code owner September 5, 2025 06:35
@Fyusel Fyusel force-pushed the ft/java-wait-handler branch 2 times, most recently from 060607e to b4e7330 Compare September 9, 2025 09:13
rubenhoenle
rubenhoenle reviewed Sep 9, 2025
View reviewed changes
@Fyusel Fyusel force-pushed the ft/java-wait-handler branch 2 times, most recently from 12a9371 to 49fb05c Compare September 10, 2025 06:29
rubenhoenle
rubenhoenle reviewed Sep 12, 2025
View reviewed changes
@Fyusel Fyusel force-pushed the ft/java-wait-handler branch 2 times, most recently from 59254e9 to 3a0eea7 Compare September 12, 2025 10:03
@Fyusel Fyusel force-pushed the ft/java-wait-handler branch 3 times, most recently from 9a4750e to 8ad2045 Compare October 16, 2025 09:58
rubenhoenle
rubenhoenle reviewed Oct 16, 2025
View reviewed changes
@Fyusel Fyusel force-pushed the ft/java-wait-handler branch 2 times, most recently from 129d48a to 2ec4b01 Compare October 20, 2025 12:00
rubenhoenle
rubenhoenle reviewed Oct 24, 2025
View reviewed changes
@Fyusel Fyusel force-pushed the ft/java-wait-handler branch from 2ec4b01 to f9caa81 Compare October 24, 2025 11:11
@Fyusel Fyusel force-pushed the ft/java-wait-handler branch from f9caa81 to e0b4869 Compare October 24, 2025 11:59
@Fyusel Fyusel force-pushed the ft/java-wait-handler branch from e0b4869 to ae58dc9 Compare October 24, 2025 12:22
@Fyusel
Add changelogs
ef42e4b 
Signed-off-by: Alexander Dahmen <[email protected]>
@Fyusel Fyusel force-pushed the ft/java-wait-handler branch from ae58dc9 to ef42e4b Compare October 24, 2025 12:54
rubenhoenle
rubenhoenle reviewed Oct 24, 2025
View reviewed changes
CHANGELOG.md
@@ -1,4 +1,8 @@
## Release (2025-xx-xx)
- `core`: [v0.4.0](core/CHANGELOG.md#v040)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick, but please combine the changelogs for the core module with the entry from below 😄

rubenhoenle
rubenhoenle approved these changes Oct 24, 2025
View reviewed changes
CONTRIBUTION.md
Let's suppose you want to implement the waiters for the `Create`, `Update` and `Delete` operations of a resource `bar` of service `foo`:

1. Start by creating a new Java package `cloud.stackit.sdk.<service>.wait` inside `services/foo/` project, if it doesn't exist yet
2. Create a file `FooWait.java` inside your new Java package `cloud.stackit.sdk.resourcemanager.wait`, if it doesn't exist yet. The class should be named `FooWait`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. Create a file `FooWait.java` inside your new Java package `cloud.stackit.sdk.resourcemanager.wait`, if it doesn't exist yet. The class should be named `FooWait`.
2. Create a file `FooWait.java` inside your new Java package `cloud.stackit.sdk.<service>.wait`, if it doesn't exist yet. The class should be named `FooWait`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rubenhoenle rubenhoenle rubenhoenle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Fyusel @rubenhoenle