Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test package with PHP 8.4 #159

Merged
merged 2 commits into from
Dec 1, 2024
Merged

Test package with PHP 8.4 #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf87d4e
Test package with PHP 8.4
Nov 30, 2024
37e4634
Fix
Dec 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ CI_CLOUD_TASKS_PROJECT_ID=
CI_CLOUD_TASKS_QUEUE=
CI_CLOUD_TASKS_LOCATION=
CI_CLOUD_TASKS_SERVICE_ACCOUNT_EMAIL=
CI_SERVICE_ACCOUNT_JSON_KEY=
CI_SERVICE_ACCOUNT_JSON_KEY_PATH=
5 changes: 4 additions & 1 deletion .github/workflows/run-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,13 @@ jobs:
matrix:
db: ['mysql', 'pgsql']
payload:
- { queue: 'github-actions-laravel10-php84', laravel: '10.*', php: '8.4', 'testbench': '8.*'}
- { queue: 'github-actions-laravel10-php83', laravel: '10.*', php: '8.3', 'testbench': '8.*'}
- { queue: 'github-actions-laravel10-php82', laravel: '10.*', php: '8.2', 'testbench': '8.*'}
- { queue: 'github-actions-laravel10-php81', laravel: '10.*', php: '8.1', 'testbench': '8.*'}
- { queue: 'github-actions-laravel11-php82', laravel: '11.*', php: '8.2', 'testbench': '9.*' }
- { queue: 'github-actions-laravel12-php83', laravel: '11.*', php: '8.3', 'testbench': '9.*' }
- { queue: 'github-actions-laravel11-php83', laravel: '11.*', php: '8.3', 'testbench': '9.*' }
- { queue: 'github-actions-laravel11-php84', laravel: '11.*', php: '8.4', 'testbench': '9.*' }

name: PHP ${{ matrix.payload.php }} - Laravel ${{ matrix.payload.laravel }} - DB ${{ matrix.db }}

Expand Down Expand Up @@ -114,4 +116,5 @@ jobs:
CI_CLOUD_TASKS_CUSTOM_QUEUE: ${{ matrix.payload.queue }}
run: |
echo $CI_SERVICE_ACCOUNT_JSON_KEY > tests/Support/gcloud-key-valid.json
touch .env
vendor/bin/phpunit
2 changes: 1 addition & 1 deletion app.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM serversideup/php:8.3-fpm
FROM serversideup/php:8.4-fpm

USER root
RUN install-php-extensions bcmath
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ services:
- .env
volumes:
- .:/var/www/html
- ${CI_SERVICE_ACCOUNT_JSON_KEY}:/var/www/html/tests/Support/gcloud-key-valid.json
- ${CI_SERVICE_ACCOUNT_JSON_KEY_PATH-./tests/Support/gcloud-key-valid.json}:/var/www/html/tests/Support/gcloud-key-valid.json
mysql:
image: mysql:8
ports:
Expand Down
1 change: 0 additions & 1 deletion tests/CloudTasksApiTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ protected function setUp(): void
'CI_CLOUD_TASKS_QUEUE',
'CI_CLOUD_TASKS_LOCATION',
'CI_CLOUD_TASKS_SERVICE_ACCOUNT_EMAIL',
'CI_SERVICE_ACCOUNT_JSON_KEY',
];

foreach ($requiredEnvs as $env) {
Expand Down
Loading