-
Notifications
You must be signed in to change notification settings - Fork 138
Fix CI failure #2363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI failure #2363
Conversation
dmartinol
commented
Oct 29, 2025
- extracted common action to generate the version tag
- replaced + with _ in the action instead of using sed later
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2363 +/- ##
=======================================
Coverage 53.79% 53.80%
=======================================
Files 254 254
Lines 24509 24509
=======================================
+ Hits 13185 13187 +2
+ Misses 10040 10039 -1
+ Partials 1284 1283 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I think the CI failures were unrelated and I just rescheduled them |
|
The job is failing because it can't download the helm binary. I can reproduce the same issue locally: wget https://get.helm.sh/helm-v3.18.4-linux-amd64.tar.gz
--2025-10-29 18:01:51-- https://get.helm.sh/helm-v3.18.4-linux-amd64.tar.gz
Resolving get.helm.sh (get.helm.sh)... 13.107.213.64, 13.107.246.64
Connecting to get.helm.sh (get.helm.sh)|13.107.213.64|:443... |
Looks like there's a general issue accessing https://get.helm.sh. |
Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!