Skip to content

Conversation

@dmartinol
Copy link
Collaborator

  • extracted common action to generate the version tag
  • replaced + with _ in the action instead of using sed later

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.80%. Comparing base (6c2a83e) to head (ea59ce6).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2363   +/-   ##
=======================================
  Coverage   53.79%   53.80%           
=======================================
  Files         254      254           
  Lines       24509    24509           
=======================================
+ Hits        13185    13187    +2     
+ Misses      10040    10039    -1     
+ Partials     1284     1283    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jhrozek
Copy link
Contributor

jhrozek commented Oct 29, 2025

I think the CI failures were unrelated and I just rescheduled them

@jhrozek
Copy link
Contributor

jhrozek commented Oct 29, 2025

The job is failing because it can't download the helm binary. I can reproduce the same issue locally:

wget https://get.helm.sh/helm-v3.18.4-linux-amd64.tar.gz
--2025-10-29 18:01:51--  https://get.helm.sh/helm-v3.18.4-linux-amd64.tar.gz
Resolving get.helm.sh (get.helm.sh)... 13.107.213.64, 13.107.246.64
Connecting to get.helm.sh (get.helm.sh)|13.107.213.64|:443...

@TomerFi
Copy link
Contributor

TomerFi commented Oct 29, 2025

The job is failing because it can't download the helm binary. I can reproduce the same issue locally:

Looks like there's a general issue accessing https://get.helm.sh.

helm/helm#31434

@dmartinol
Copy link
Collaborator Author

Note: I added a bunch of lint fixes probably due to a new version of golangci-lint
@jhrozek @JAORMX ^

Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dmartinol dmartinol enabled auto-merge (squash) October 30, 2025 09:46
@dmartinol dmartinol merged commit 7644d08 into stacklok:main Oct 30, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants