Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests added #25

Merged
merged 12 commits into from
Jun 29, 2024
Merged

Tests added #25

merged 12 commits into from
Jun 29, 2024

Conversation

Dhruv-2003
Copy link
Contributor

Closes #20

This PR adds tests to test the flow of the MRU for 4 & 6 team variant tournaments, also covering basic edge cases with respect to odd no of teams in certain round.

@aashutoshrathi aashutoshrathi self-requested a review June 28, 2024 15:34
Copy link
Member

@aashutoshrathi aashutoshrathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1/n

tests/mru-6.test.ts Outdated Show resolved Hide resolved
tests/mru-6.test.ts Outdated Show resolved Hide resolved
tests/mru-6.test.ts Show resolved Hide resolved
Copy link
Member

@aashutoshrathi aashutoshrathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Picked few nits and tons of array related similar checks. Can we do them?

tests/mru-4.test.ts Outdated Show resolved Hide resolved
tests/mru-6.test.ts Outdated Show resolved Hide resolved
tests/mru-6.test.ts Outdated Show resolved Hide resolved
tests/mru-6.test.ts Outdated Show resolved Hide resolved
@aashutoshrathi aashutoshrathi merged commit aaadee1 into main Jun 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for different tournament variations
2 participants