Improve syscalls worker #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erthalion
force-pushed
the
feature/syscalls
branch
2 times, most recently
from
d3345f9 to
d00073c
Compare
Molter73
approved these changes
Aug 12, 2024
src/worker/syscalls.rs
Outdated
| counter += 1; | ||
| // Do the syscall directly, without spawning a thread (it would | ||
| // introduce too much overhead for a quick syscall). | ||
| worker.do_syscall(syscall).unwrap(); |
There was a problem hiding this comment.
Panicking here is probably fine, but returning an error could be a bit more user friendly.
There was a problem hiding this comment.
Eventually I got rid of the result altogether, to get slightly less overhead per iteration.
erthalion
force-pushed
the
feature/syscalls
branch
from
d00073c to
2172357
Compare
Remove unneeded thread spawning (this will produce more load), allow to run in a tight loop and to specify the syscall.
erthalion
force-pushed
the
feature/syscalls
branch
from
2172357 to
0bab235
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unneeded thread spawning (this will produce more load), allow to run in a tight loop and to specify the syscall.