-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow running berserker on k8s with configuration #5
base: main
Are you sure you want to change the base?
Conversation
k8s/berserker.yml
Outdated
effect: NoSchedule | ||
containers: | ||
- name: berserker | ||
image: quay.io/rhacs-eng/qa:berserker-1.0-35-g3d1715a7f3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update to the latest tag 1.0-40-ge3bd96aa5a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want to add an imagePullSecret. Currently this doesn't work on infra, because it cannot pull the image.
I don't know if I did this the best way, but you can look at how I did this for the long running cluster. Also you will need to make some changes as this is for kube-burner. ACS itself has some other method for setting imagePullSecrets.
Secret template
https://github.com/stackrox/stackrox/blob/master/scripts/release-tools/kube-burner-configs/secret_template.yml
Berserker deployment that uses the secret
https://github.com/stackrox/stackrox/blob/master/scripts/release-tools/kube-burner-configs/cluster-density/deployment.yml
Script that creates the secret from the secret template
https://github.com/stackrox/actions/blob/main/release/start-kube-burner/start-kube-burner.sh
I did the following test
In a separate terminal run any of the collector integration tests
This integration test doesn't exist in the master branch but any of them will do
When using the berserker-1.0-35-g3d1715a7f3 no endpoints are observed
Change the image tag to berserker-1.0-40-ge3bd96aa5a Run the collector integration test again
Many other endpoints are observed. Repeat the test for the other config files. |
Perhaps in the future we could have some integration tests to make sure that we are getting the desired load from berserker. |
k8s/endpoints-zipf.yml
Outdated
@@ -0,0 +1,14 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ultra nit] The other files don't start with a blank space.
@@ -0,0 +1,39 @@ | |||
--- | |||
apiVersion: apps/v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file names could be improved. They could be either prefixed or suffixed with the kind. E.g berserker-daemonset.yml.
db07469
to
b4e751a
Compare
This PR adds a basic yaml file that allows running berserker as a daemon set and use configmaps to control its behavior.
For now the image being configured is one on
quay.io/rhacs-eng/qa
, but it'd be great to update it to a tagged version if we ever do one of those.