Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build ARM64 images #1359

Merged
merged 7 commits into from
Nov 2, 2023
Merged

Build ARM64 images #1359

merged 7 commits into from
Nov 2, 2023

Conversation

Molter73
Copy link
Collaborator

@Molter73 Molter73 commented Oct 6, 2023

Description

GCP added ARM VMs last year. With the effort to support Power and Z architectures that has been ongoing for about the past year as well, it is relatively easy to enable collector builds for ARM and add integration tests for it using CO-RE BPF thanks to Falco supporting the architecture already. So, this PR adds ARM image builds for collector and tests them on GCP.

Checklist

  • Investigated and inspected CI test results

Testing Performed

CI should be enough.

@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@Molter73 Molter73 force-pushed the mauro/test-arm64 branch 3 times, most recently from fd81034 to db35330 Compare October 9, 2023 14:44
@github-actions
Copy link

github-actions bot commented Oct 10, 2023

Kernel Method Without Collector Time (secs) With Collector Time (secs) Baseline median (secs) Collector median (secs) PValue

@Molter73 Molter73 force-pushed the mauro/test-arm64 branch 2 times, most recently from 2a308ee to 508fa40 Compare October 11, 2023 08:59
@Molter73 Molter73 mentioned this pull request Oct 11, 2023
1 task
@robbycochran
Copy link
Collaborator

Nice! Tests passing on arm64!

@Molter73 Molter73 changed the title Try building arm64 collector-slim Build ARM64 images Oct 18, 2023
@Molter73 Molter73 added the run-multiarch-builds Run steps for non-x86 archs. label Oct 19, 2023
@Molter73 Molter73 requested a review from robbycochran October 19, 2023 16:23
@Molter73 Molter73 marked this pull request as ready for review October 19, 2023 16:23
@Molter73 Molter73 requested a review from a team as a code owner October 19, 2023 16:23
@Molter73 Molter73 added the run-cpaas-steps Trigger CI steps related to cPaaS label Oct 23, 2023
@Molter73 Molter73 force-pushed the mauro/test-arm64 branch 2 times, most recently from 9a0a8b3 to 1789336 Compare October 23, 2023 09:09
@Molter73 Molter73 removed the run-cpaas-steps Trigger CI steps related to cPaaS label Oct 24, 2023
Copy link
Collaborator

@Stringy Stringy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is excellent, and demonstrates all the work we put into multi-arch was worth the effort!

.github/workflows/collector-full.yml Show resolved Hide resolved
.github/workflows/integration-tests.yml Outdated Show resolved Hide resolved
.github/workflows/integration-tests.yml Show resolved Hide resolved
.github/workflows/collector-full.yml Show resolved Hide resolved
@Molter73 Molter73 merged commit 5473abb into master Nov 2, 2023
53 checks passed
@Molter73 Molter73 deleted the mauro/test-arm64 branch November 2, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants