Impove group_vars docs and move s390x vars to create-vm role #1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Molter73
reviewed
Oct 9, 2023
Comment on lines
8
to
15
| # subnet_name: stackrox-ci-sn3 | ||
| s390x_subnet_id: 02s7-0fca7f4f-7e53-40d5-a087-f8cb5d7ab682 | ||
| s390x_zone: ca-tor-3 | ||
| # ssh_key_name: acs-sshkey | ||
| s390x_ssh_key_id: r038-fb0260c7-c01d-45c8-8026-7d50042943b9 | ||
| # vsi_resource_group: stackrox-ci-resource-group | ||
| s390x_vsi_resource_group_id: 1a33a6a9bd6e498f8115e9b1064bfa97 |
There was a problem hiding this comment.
Maybe we can group all of these in a s390x dictionary?
Suggested change
| s390x_vpc_id: r038-c4f8e233-4b56-44bd-af71-140ebd1664e9 | |
| # subnet_name: stackrox-ci-sn3 | |
| s390x_subnet_id: 02s7-0fca7f4f-7e53-40d5-a087-f8cb5d7ab682 | |
| s390x_zone: ca-tor-3 | |
| # ssh_key_name: acs-sshkey | |
| s390x_ssh_key_id: r038-fb0260c7-c01d-45c8-8026-7d50042943b9 | |
| # vsi_resource_group: stackrox-ci-resource-group | |
| s390x_vsi_resource_group_id: 1a33a6a9bd6e498f8115e9b1064bfa97 | |
| s390x: | |
| vpc_id: r038-c4f8e233-4b56-44bd-af71-140ebd1664e9 | |
| # subnet_name: stackrox-ci-sn3 | |
| subnet_id: 02s7-0fca7f4f-7e53-40d5-a087-f8cb5d7ab682 | |
| zone: ca-tor-3 | |
| # ssh_key_name: acs-sshkey | |
| ssh_key_id: r038-fb0260c7-c01d-45c8-8026-7d50042943b9 | |
| # vsi_resource_group: stackrox-ci-resource-group | |
| vsi_resource_group_id: 1a33a6a9bd6e498f8115e9b1064bfa97 |
According to the ansible docs we could then access them with dot notation, i.e: s390x.vpc_id
https://docs.ansible.com/ansible/latest/playbook_guide/playbooks_variables.html#dictionary-variables
There was a problem hiding this comment.
that is much cleaner, I'll implement it now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just some tidy up and minor refactoring of ansible vars files. CI should be sufficient for testing.