-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control normalization in network introspection API #1693
Conversation
return true; | ||
} | ||
|
||
return *normalize_flag == "true"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit] Should be insensitive to capitalization.
Can you improve the PR description to show how this can be used, and show example output with and without normalization? Also can you explain how you tested it? Did you deploy ACS with this collector version? |
@JoukoVirtanen Thanks for the review :) Added a link to the updated doc in the PR description. This contains a usage example with corresponding result. |
I have tested this. I checked out the master branch of stackrox/stackrox. Ran
to the list of environment variables. Ran
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing the nit is optional.
Description
With normalization always enabled, the introspection API cannot be used to retrieve all IP addresses. So we add a parameter to disable it.
Link to the updated documentation: https://github.com/stackrox/collector/blob/ovalenti/conn_introspection_no_normalize/docs/troubleshooting.md#network-endpoint
Checklist
normalize=false