Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unblock drivers for RHEL 9.4+ on 2.9.1 #1696

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

Molter73
Copy link
Collaborator

@Molter73 Molter73 commented Jun 3, 2024

Description

eBPF drivers for RHEL 9.4 should be supported starting with version 2.9.1

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

Run with build-legacy-probes label.

@robbycochran robbycochran requested review from robbycochran and removed request for robbycochran June 5, 2024 22:42
@robbycochran
Copy link
Collaborator

The BLOCKLIST change looks good, but RHEL 9.4 builds are failing on collector_probe.c

In file included from /kobuild-tmp/versions-src/2.9.1/collector-probe/collector_probe.c:32:
/kobuild-tmp/versions-src/2.9.1/bpf/fillers.h:862:56: error: member reference base type 'struct percpu_counter[4]' is not a structure or union
        bpf_probe_read_kernel(&val, sizeof(val), &mm->rss_stat.count[member]);
                                                  ~~~~~~~~~~~~^~~~~~

@Molter73
Copy link
Collaborator Author

Molter73 commented Jun 6, 2024

The BLOCKLIST change looks good, but RHEL 9.4 builds are failing on collector_probe.c

In file included from /kobuild-tmp/versions-src/2.9.1/collector-probe/collector_probe.c:32:
/kobuild-tmp/versions-src/2.9.1/bpf/fillers.h:862:56: error: member reference base type 'struct percpu_counter[4]' is not a structure or union
        bpf_probe_read_kernel(&val, sizeof(val), &mm->rss_stat.count[member]);
                                                  ~~~~~~~~~~~~^~~~~~

#1695 will fix this issue, I'm holding off on merging this one until that one goes through, we should get it in by end of day today.

@Molter73 Molter73 force-pushed the mauro/unblock-el94-drivers branch from af8d472 to 9873f88 Compare June 6, 2024 13:10
@Molter73 Molter73 marked this pull request as ready for review June 6, 2024 13:10
@Molter73 Molter73 requested a review from a team as a code owner June 6, 2024 13:10
@Molter73 Molter73 force-pushed the mauro/unblock-el94-drivers branch from 9873f88 to 4ffa837 Compare June 7, 2024 15:27
@Molter73 Molter73 merged commit 2402b32 into master Jun 7, 2024
47 checks passed
@Molter73 Molter73 deleted the mauro/unblock-el94-drivers branch June 7, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants