Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROX-20236: Set release Dockerfile label explicitly #1705

Merged
merged 1 commit into from
Jun 7, 2024
Merged

ROX-20236: Set release Dockerfile label explicitly #1705

merged 1 commit into from
Jun 7, 2024

Conversation

msugakov
Copy link
Contributor

@msugakov msugakov commented Jun 6, 2024 •
edited
Loading

Description

Per title, plus a few cosmetics.

Checklist

  • Investigated and inspected CI test results

This isn't needed:

  • Updated documentation accordingly

Automated testing

Did not add these:

  • Added unit tests
  • Added integration tests
  • Added regression tests

Testing Performed

  • Pulled the image and checked that release is set to 1.

@msugakov
Set release Dockerfile label explicitly
d957236 
Also added comment around `version` and added some blank lines.
@msugakov
Copy link
Contributor Author

msugakov commented Jun 7, 2024

/retest

@msugakov msugakov marked this pull request as ready for review June 7, 2024 13:41
@msugakov msugakov requested a review from a team as a code owner June 7, 2024 13:41
@msugakov msugakov merged commit b92505c into master Jun 7, 2024
129 of 153 checks passed
@msugakov msugakov deleted the misha/ROX-20236-set-release-label-konflux branch June 7, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Molter73 Molter73 Molter73 approved these changes

@kylape kylape Awaiting requested review from kylape

@tommartensen tommartensen Awaiting requested review from tommartensen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msugakov @Molter73