Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust buffer size instead of cpu-per-core #1706

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Commits on Jun 11, 2024

  1. Adjust buffer size instead of cpu-per-core

    It turns out making many CPU cores working with a single ringbuf has a
    potential deadlock hazard, especially visible on RT kernels. To avoid
    even a slightest danger, reduce ringbuf size instead. In the new
    scenario if we do not fit into the total ringbuf size, the size of each
    individual ringbuf will be adjusted and aligned for readability.
    erthalion committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    d8380af View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Convert size options to long

    Currently used int type is not enough when it comes to values like a few
    GiB, expressed in the number of bytes, making it impossible to set some
    reasonable values. Use long type for ROX_COLLECTOR_SINSP_BUFFER_SIZE,
    ROX_COLLECTOR_SINSP_TOTAL_BUFFER_SIZE,
    ROX_COLLECTOR_SINSP_THREAD_CACHE_SIZE.
    erthalion committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    a7af9d5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6906c14 View commit details
    Browse the repository at this point in the history