Removes driver downloads and driver candidates #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Molter73
reviewed
Aug 2, 2024
Molter73
reviewed
Aug 2, 2024
Comment on lines
+22
to
+23
| CLOG(WARNING) << "Unexpected CollectionMethod: " << static_cast<uint8_t>(method); | ||
| return "unknown"; |
There was a problem hiding this comment.
I would argue ERROR is a more appropriate severity, since we are not going to be able to continue working with an invalid collection method. I would go as far as to go into FATAL, but I'm an extremist.
There was a problem hiding this comment.
Yeah I went for a warning just due to the function's purpose -- other parts of the codebase can be a bit more strict about validating the collection method (in fact in CollectorConfig.cpp it's switching to CORE_BPF on an invalid method, so I think we're safe)
Molter73
approved these changes
Aug 2, 2024
Stringy
added a commit
that referenced
this pull request
Aug 2, 2024
Molter73
added a commit
that referenced
this pull request
Aug 5, 2024
This commit started as an attempt to remove the MODULE_VERSION file, but is quickly devolved into removing a lot of unused code. Namely: - Removed the MODULE_VERSION file and all direct and indirect references to it in collector code, ansible playbooks, docker files, GHA workflows, etc.. - Removed support-package scripts that were unused and would be broken after removing the MODULE_VERSION file. - Removed code and references to the /module directory that would be unused after #1770. This also triggered some additional cleanup on constants and environment variables associated to driver downloads that were leftover. - Fixed a CMake warning due to cmake_minimum_required directive being called after the project directive. - Removed the WITH_CHISEL configuration since chisels have been removed from upstream and it is no longer being used after the latest falco update. - Updated docs as best as possible.
5 tasks
Molter73
added a commit
that referenced
this pull request
Aug 5, 2024
This commit started as an attempt to remove the MODULE_VERSION file, but is quickly devolved into removing a lot of unused code. Namely: - Removed the MODULE_VERSION file and all direct and indirect references to it in collector code, ansible playbooks, docker files, GHA workflows, etc.. - Removed support-package scripts that were unused and would be broken after removing the MODULE_VERSION file. - Removed code and references to the /module directory that would be unused after #1770. This also triggered some additional cleanup on constants and environment variables associated to driver downloads that were leftover. - Fixed a CMake warning due to cmake_minimum_required directive being called after the project directive. - Removed the WITH_CHISEL configuration since chisels have been removed from upstream and it is no longer being used after the latest falco update. - Updated docs as best as possible.
Molter73
added a commit
to stackrox/stackrox
that referenced
this pull request
Aug 5, 2024
After stackrox/collector#1770, collector is no longer able to download drivers, so the /module directory is now effectively unused and can safely be removed from the helm charts.
9 tasks
Molter73
added a commit
that referenced
this pull request
Aug 6, 2024
This commit started as an attempt to remove the MODULE_VERSION file, but is quickly devolved into removing a lot of unused code. Namely: - Removed the MODULE_VERSION file and all direct and indirect references to it in collector code, ansible playbooks, docker files, GHA workflows, etc.. - Removed support-package scripts that were unused and would be broken after removing the MODULE_VERSION file. - Removed code and references to the /module directory that would be unused after #1770. This also triggered some additional cleanup on constants and environment variables associated to driver downloads that were leftover. - Fixed a CMake warning due to cmake_minimum_required directive being called after the project directive. - Removed the WITH_CHISEL configuration since chisels have been removed from upstream and it is no longer being used after the latest falco update. - Updated docs as best as possible.
Molter73
added a commit
to stackrox/stackrox
that referenced
this pull request
Aug 7, 2024
After stackrox/collector#1770, collector is no longer able to download drivers, so the /module directory is now effectively unused and can safely be removed from the helm charts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Final (?) removal of driver downloads and collection method switching. This removes the file downloader, the kernel object downloader, driver candidates, and thus simplifies various places where they were used.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.
For more details, ref the Confluence page about this section.