Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for existence of MODULE_VERSION file #1782

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

Molter73
Copy link
Collaborator

@Molter73 Molter73 commented Aug 7, 2024

Description

#1773 removed the MODULE_VERSION file, so when syncing support packages from downstream, we should skip versions that don't have this file.

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

Run with run-cpaas-steps label.

@Molter73 Molter73 added the run-cpaas-steps Trigger CI steps related to cPaaS label Aug 7, 2024
@Molter73 Molter73 requested a review from a team as a code owner August 7, 2024 09:27
@Molter73
Copy link
Collaborator Author

Molter73 commented Aug 7, 2024

Downstream tests are broken because we are not creating the /module directory anymore, bumping the version on the main repo should fix them, so I won't take those failures as a blocker for merging this PR.

We'll update the main repo ASAP.

@Molter73 Molter73 changed the title Check for existance of MODULE_VERSION file Check for existence of MODULE_VERSION file Aug 7, 2024
@Molter73 Molter73 merged commit 8a2a92e into master Aug 7, 2024
53 of 57 checks passed
@Molter73 Molter73 deleted the mauro/fix-support-package-sync branch August 7, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-cpaas-steps Trigger CI steps related to cPaaS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants