Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes SSH and GCP command builders #1786

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

Stringy
Copy link
Collaborator

@Stringy Stringy commented Aug 12, 2024

Description

The SSH and GCP command builders are no longer used. This PR simply removes them. CI testing should be sufficient.

@Stringy Stringy requested a review from a team as a code owner August 12, 2024 12:17
Copy link
Contributor

@ovalenti ovalenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stringy
Copy link
Collaborator Author

Stringy commented Aug 12, 2024

Do we still have a use of Host.Kind ?

We do, because it's used to differentiate between local tests and k8s tests, but the rest of the HostInfo config values I think are unused, so I've removed them.

@Stringy Stringy requested a review from ovalenti August 12, 2024 14:03
Copy link
Contributor

@ovalenti ovalenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks all good to me !

@Molter73
Copy link
Collaborator

Molter73 commented Aug 12, 2024

Do we still have a use of Host.Kind ?

We do, because it's used to differentiate between local tests and k8s tests, but the rest of the HostInfo config values I think are unused, so I've removed them.

Not something to do as part of this PR, but given that tests are meant to either run on docker or k8s (at least the way they are put together now), we can probably delegate the decision of what kind of runner to use to the tests themselves, instead of making it configurable and risk someone attempting to run tests on a system they are not meant to work on.

If we ever put together a test that is able to run on docker or k8s independently we might need to put some mechanism for this back in place, but I don't think we have plans to do this any time soon.

@Stringy
Copy link
Collaborator Author

Stringy commented Aug 12, 2024

we can probably delegate the decision of what kind of runner to use to the tests themselves

Yeah good point. I'll do that in a follow up.

@Stringy Stringy merged commit 43bd7f7 into master Aug 12, 2024
35 checks passed
@Stringy Stringy deleted the giles/remove-unused-command-builders branch August 12, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants