Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Adjust timeout waiting for Konflux images #1795

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

msugakov
Copy link
Contributor

@msugakov msugakov commented Aug 14, 2024

Description

I noticed that GHA builds were failing on me https://github.com/stackrox/collector/actions/runs/10375095581/job/28724093219

This should fix it.

Checklist

  • Investigated and inspected CI test results
  • [ ] Updated documentation accordingly

Automated testing

No change to automated tests.

Testing Performed

GHA should pass.

@msugakov msugakov requested review from a team as code owners August 14, 2024 08:58
@msugakov
Copy link
Contributor Author

/retest collector-build

Copy link

openshift-ci bot commented Aug 14, 2024

@msugakov: No presubmit jobs available for stackrox/collector@master

In response to this:

/retest collector-build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@msugakov
Copy link
Contributor Author

When Konflux build fails, wait-for-images does not know that and keeps waiting for images. That's something to be fixed, but too much for this PR. At least here I saw it waiting. Just want to see GHA konflux workflows succeeding.

@Molter73
Copy link
Collaborator

When Konflux build fails, wait-for-images does not know that and keeps waiting for images. That's something to be fixed, but too much for this PR. At least here I saw it waiting. Just want to see GHA konflux workflows succeeding.

Yeah, the wait-for-images step is not smart enough, it only checks if the image is available in the registry, not if the konflux workflow is running. I believe the main repo has the same issue since it uses this action, but unless we get some clear way to get the konflux cluster that is running associated to a given GHA workflow so that we can query some sort of API/hook in there, I don't know if we can do any better.

In any case, as you say, this is not to be addressed in this PR.

@msugakov msugakov merged commit ef3d1b4 into master Aug 15, 2024
68 of 69 checks passed
@msugakov msugakov deleted the misha/adjust-wait-for-konflux-images-timeout branch August 15, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants