Update Falco bumping instructions #1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the removal of the MODULE_VERSION file in #1773 our handling of the falco libs fork is somewhat outdated, since now there is no module version to use as a guideline. Instead, I'm proposing that we start using the upstream version we are based on as part of our branching strategy. With this new approach, branches with our changes will be of the form M.m.p-stackrox, with M.m.p being the version numbers for the upstream libs tag the branch is based on.
Stringy
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the removal of the MODULE_VERSION file in #1773 our handling of the falco libs fork is somewhat outdated, since now there is no module version to use as a guideline. Instead, I'm proposing that we start using the upstream version we are based on as part of our branching strategy.
With this new approach, branches with our changes will be of the form M.m.p-stackrox, with M.m.p being the version numbers for the upstream libs tag the branch is based on.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
This is a documentation only PR, no testing is necessary.