Do not process gcloudignore files when uploading support-packages #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a minor change, we are getting some error message on the upload support packages steps from the CPaaS workflows because the google-github-actions/upload-cloud-storage action expects a gcloudignore to be present by default. Since we don't expect to process this kind of file, we just set the option to false on all occurrences of the action. Without this change the actions still worked correctly, this is merely to get rid of the annoying error messages in the CI output.
Molter73
added
run-cpaas-steps
Stringy
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a minor change, we are getting some error message on the upload support packages steps from the CPaaS workflows because the google-github-actions/upload-cloud-storage action expects a gcloudignore to be present by default. Since we don't expect to process this kind of file, we just set the option to false on all occurrences of the action.
Without this change the actions still worked correctly, this is merely to get rid of the annoying error messages in the CI output.
Examples of the errors can be found here: https://github.com/stackrox/collector/actions/runs/10609617180/job/29405734430
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed