Setup CMakePresets.json #1840
Open
Setup CMakePresets.json #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Molter73
force-pushed
the
mauro/add-cmake-presets
branch
from
377264b
to
31be26e
Compare
A few basic presets have been setup, allowing to compile collector in release or debug mode, as well as using sanitizers and valgrind. CMakeUserPresets.json can be used to add other dedicated presets that people could need. Where possible, presets are now being used, sometimes providing other definitions that could be needed. In order to prevent presets from being broken by future changes, a schema validation pre-commit hook has been added that should also be enforced in CI. Lastly, some option directives have been added to collector/CMakeLists.txt as an additional effort to have a centralized place for these to be defined and provide default values for them.
Molter73
force-pushed
the
mauro/add-cmake-presets
branch
from
b32c240
to
f41fa03
Compare
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few basic presets have been setup, allowing to compile collector in release or debug mode, as well as using sanitizers and valgrind. CMakeUserPresets.json can be used to add other dedicated presets that people could need. Where possible, presets are now being used, sometimes providing other definitions that could be needed. In order to prevent presets from being broken by future changes, a schema validation pre-commit hook has been added that should also be enforced in CI.
Lastly, some option directives have been added to
collector/CMakeLists.txt as an additional effort to have a centralized place for these to be defined and provide default values for them.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed