Pin GHA runners to ubuntu-24.04 #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Molter73
added
run-cpaas-steps
Molter73
force-pushed
the
mauro/ubuntu-24.04
branch
from
4302971 to
47a4f9d
Compare
Molter73
changed the title
Stringy
approved these changes
Sep 23, 2024
ansible/Makefile
Outdated
| @@ -29,7 +29,7 @@ provision-vms: | |||
|
|
|||
| .PHONY: destroy-vms | |||
| destroy-vms: | |||
| ansible-playbook -i $(CONTEXT) \ | |||
| ansible-playbook -i $(CONTEXT) -vvvv \ | |||
There was a problem hiding this comment.
What's the purpose of the extra logging?
There was a problem hiding this comment.
I did this because of a weird flake I got, but then the issue never happened again and I forgot to remove the verbosity, I'll roll it back before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Having runners configured to
ubuntu-latestmeans that the underlying VM could be updated to a newer version without us knowing. This should only be a problem when a new LTS version of Ubuntu is made the default for GHA and shouldn't be a major problem for us, since we mostly use generic tools pre-installed on all runners but, just in case, we should be explicit about what version of runner we want to use.Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
Run as many workflows as possible and checked none of them is broken.