Only load interesting syscalls #1855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Molter73
force-pushed
the
mauro/load-interesting-syscalls
branch
from
ba03c0d
to
1207bff
Compare
Stringy
approved these changes
Sep 24, 2024
| @@ -45,6 +45,7 @@ jobs: | |||
| - integration-tests/Dockerfile | |||
| - .github/workflows/integration-test-containers.yml | |||
|
|
|||
| # Trigger rebuild | |||
There was a problem hiding this comment.
Shouldn't it be rebuilding anyway, or is the list of filters above not working properly?
There was a problem hiding this comment.
It is not triggering because this PR doesn't have any changes to the files in the filter. I was gonna suggest we should add the base argument, but the docs say this is ignored when the trigger is pull_request, so not entirely sure what we could do about it 🤷🏻♂️
Molter73
force-pushed
the
mauro/track-mmsg-syscalls
branch
from
f845238
to
9fc81e5
Compare
Molter73
force-pushed
the
mauro/load-interesting-syscalls
branch
from
c732f6c
to
bfff81e
Compare
Molter73
force-pushed
the
mauro/track-mmsg-syscalls
branch
from
370a7fe
to
880d840
Compare
Molter73
force-pushed
the
mauro/load-interesting-syscalls
branch
from
bfff81e
to
487b36c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a small-ish change that makes it so tracepoints associated to syscalls that are not interesting will not be loaded. With this change, we can decide to exclude a tracepoint at runtime, for instance to work around a verifier issue.
In particular, the new implementations for sendmmsg and recvmmsg tracepoints have verifier issues, because these syscalls are opt-in, people that don't enable these syscalls should also not hit the verifier issue.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed