Remove unneeded packages from final collector image #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reasoning for removing each package: - kmod has not been needed since we stopped supporting kernel modules - libyaml and libarchive have vulnerabilities, are unused by the the collector binary and show no other package depend on them when querying with rpm. - Replaced xargs rpm -e with the method used in konflux.Dockerfile, so findutils is no longer needed either.
Molter73
force-pushed
the
mauro/remove-unneeded-dependencies
branch
from
98d6144 to
4ad134b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reasoning for removing each package:
xargs rpm -ewith the method used in konflux.Dockerfile, so findutils is no longer needed either.Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed