Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use python:3.12-slim for plop.py #1865

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Use python:3.12-slim for plop.py #1865

merged 1 commit into from
Sep 26, 2024

Conversation

Molter73
Copy link
Collaborator

@Molter73 Molter73 commented Sep 26, 2024

Description

The non-slim variant is about 1GB in size, slim is closer to 100MB.
This is not a production grade image, but still, no reason to be
bloating images for the sake of it.

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

CI should be enough.

 The non-slim variant is about 1GB in size, slim is closer to 100MB.
 This is not a production grade image, but still, no reason to be
 bloating images for the sake of it.
@Molter73 Molter73 requested a review from a team as a code owner September 26, 2024 09:20
Copy link
Collaborator

@Stringy Stringy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Molter73 Molter73 merged commit 5518702 into master Sep 26, 2024
86 of 87 checks passed
@Molter73 Molter73 deleted the mauro/plop-py-slim branch September 26, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants